Bugfix flapper power distribution #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichardsson
suggested changes
Oct 12, 2022
|
Thanks for checking, hopefully clean and fixed now :) |
krichardsson
approved these changes
Oct 13, 2022
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in #1132 and affecting only the newly introduced flapper platform.
After the changes requested by the reviewers, the
motorsStop()function was not working as intended with the flapper platform.The motor mapping in the newly introduced
powerDistributionStopRatio(id)andpowerDistributionMotorType(id)functions was incorrect, and is fixed in this PR.