Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to read multi-byte data over UART1 #1254

Merged
merged 2 commits into from Mar 22, 2023

Conversation

bhabas
Copy link
Contributor

@bhabas bhabas commented Mar 21, 2023

Currently, UART1 communication supports sending multi-byte data over a UART1 connection, but it can only receive single-byte characters. This function enhances the UART1 communication capability by enabling the reception of multi-byte data over the UART1 connection.

This feature is particularly useful for efficiently streaming low-volume data from the AI-Deck directly to the STM-32.

Copy link
Contributor

@krichardsson krichardsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, this is a nice function!
My only comment is to rename it to reflect the timeout behavior, in the same way as the other read functions. Maybe something along the lines uart1GetBytesWithDefaultTimeout?

@bhabas
Copy link
Contributor Author

bhabas commented Mar 21, 2023

Sure thing! I just made another commit adding your suggestion

@krichardsson krichardsson merged commit 1346781 into bitcraze:master Mar 22, 2023
23 checks passed
@krichardsson
Copy link
Contributor

Thanks!

@bhabas bhabas deleted the UART1_Data_Transfer branch March 22, 2023 13:20
@knmcguire knmcguire added this to the next-release milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants