Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SystemID deck functionality into master #1346

Merged
merged 45 commits into from Mar 22, 2024
Merged

Merge SystemID deck functionality into master #1346

merged 45 commits into from Mar 22, 2024

Conversation

tobbeanton
Copy link
Member

Support for the SystemID deck has been in the dev-systemId branch but is constantly getting outdated. With the Kbuild system this can now be an easy configured with "make sysid_defconfig".

whoenig and others added 30 commits February 19, 2021 15:08
@whoenig
Copy link
Contributor

whoenig commented Feb 9, 2024

excellent idea

Copy link
Member

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an objection of just merging this since it is supposed to be behind a build flag, but I'm a bit worried about the DWM1000 library submodule.... why was this updated ? Are we sure this will not cause issues with our LPS implementation?

tools/system_id/plot_motor_delay.py Show resolved Hide resolved
tools/system_id/plot_motor_delay.py Outdated Show resolved Hide resolved
tools/system_id/plot_motor_delay.py Show resolved Hide resolved
tools/system_id/plot_data.py Show resolved Hide resolved
src/drivers/src/i2c_drv.c Outdated Show resolved Hide resolved
tools/system_id/README.md Show resolved Hide resolved
@tobbeanton tobbeanton merged commit 3d5129f into master Mar 22, 2024
24 checks passed
@tobbeanton tobbeanton deleted the dev-systemId branch March 22, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants