Added Bolt 1.1 platform config and motor mapping. #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knmcguire
reviewed
Mar 16, 2022
src/drivers/src/motors_def_cf2.c
Outdated
| &BOLT_M1_BL, | ||
| &BOLT_M2_BL, | ||
| &BOLT_M3_BL, | ||
| &BOLT11_M4_BL |
There was a problem hiding this comment.
Why is this one called BOLT11_M4_BL while the other ones are called BOLT_M#_BL?
There was a problem hiding this comment.
We could decouple it from the platform and call it e.g. PA1_TIM2_CH2_BL and do the same with all of them.
| @@ -301,6 +301,31 @@ static const MotorPerifDef BOLT_M4_BL = | |||
| .preloadConfig = TIM_OC4PreloadConfig, | |||
| }; | |||
|
|
|||
| // Bolt 1.1 M4, PB10, TIM2_CH3, Brushless config | |||
There was a problem hiding this comment.
Hi is there only here a addition for motor M4?
There was a problem hiding this comment.
Yes, this is the only HW change.
knmcguire
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A finding made during motor output testing was that the expansion tests where not compiled in. Therefor these where added to Kbuild so the outputs could be tested.