Wireshark: Add parameter- and log dissection #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds dissection of the toc channel of the parameter port which enables us to know the group and name for parameter reads and writes. You can now filter on the name of a group or a name and follow it through your session. And also check the type of the parameter.
jonasdn
requested review from
ataffanel,
Bananazooka,
knmcguire,
krichardsson and
tobbeanton
jonasdn
force-pushed
the
jonasdn/wireshark_toc
branch
from
48b174c
to
37ce9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds awareness of the Logging- and parameter Table of Contents. The result is that we can see the group, name and type of logging variables and parameters.
Se images below for result after this PR: