Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step by Step Swarm Guide #352

Merged
merged 6 commits into from
Aug 11, 2022
Merged

Step by Step Swarm Guide #352

merged 6 commits into from
Aug 11, 2022

Conversation

marios-stam
Copy link
Contributor

A step-by-step guide for the Swarm class is introduced.

Could you provide feedback and other things that could be included as well?

krichardsson
krichardsson suggested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@krichardsson krichardsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tutorial! Great to explain how to use the Swarm class.
Some minor comments below.

docs/user-guides/sbs_swarm_interface.md Outdated Show resolved Hide resolved
docs/user-guides/sbs_swarm_interface.md Outdated Show resolved Hide resolved
docs/user-guides/sbs_swarm_interface.md Outdated Show resolved Hide resolved
docs/user-guides/sbs_swarm_interface.md Outdated Show resolved Hide resolved
@krichardsson krichardsson self-requested a review August 11, 2022 08:32
knmcguire
knmcguire requested changes Aug 11, 2022
View reviewed changes
Copy link
Member

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It looks good in overal but I have some comments about the highlevel commander, regarding some outdated information. There is no need anymore to enable the high level commander separately.

docs/user-guides/sbs_swarm_interface.md Outdated Show resolved Hide resolved
docs/user-guides/sbs_swarm_interface.md Outdated Show resolved Hide resolved
docs/user-guides/sbs_swarm_interface.md Outdated Show resolved Hide resolved
@marios-stam marios-stam marked this pull request as ready for review August 11, 2022 09:36
@knmcguire knmcguire merged commit a5b888b into bitcraze:master Aug 11, 2022
@knmcguire knmcguire added this to the next-release milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krichardsson krichardsson krichardsson approved these changes

@knmcguire knmcguire knmcguire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@marios-stam @krichardsson @knmcguire