Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Do not use setTemplate in Block classes #82

Closed
shochdoerfer opened this issue Mar 13, 2021 · 0 comments · Fixed by #300
Closed

Feature Request: Do not use setTemplate in Block classes #82

shochdoerfer opened this issue Mar 13, 2021 · 0 comments · Fixed by #300

Comments

@shochdoerfer
Copy link
Member

The Magento ExtDN people have a Codesniffer sniff in place to detect calls to the setTemplate() method in a block class. Read about their reasoning here. It probably makes sense to port this rule also to this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rule "Disallow setTemplate() in Block classes" shochdoerfer/phpstan-magento
1 participant
@shochdoerfer