Enabled automatic id generation

[ArnyminerZ]

Closes #116

[rfc2822]

Please rebase/merge again, I updated dependencies in the dev branch

[rfc2822]

Does this change need a migration and/or migrate automatically?

[ArnyminerZ]

@rfc2822 It should work out without any issues. It's just for new subscriptions. The old ones directly retain the ids provided by the Android calendar. See here:

icsx5/app/src/main/java/at/bitfire/icsdroid/db/entity/Subscription.kt

Lines 51 to 72 in f290664

	/**
	* Converts a [LocalCalendar] to a [Subscription] data object.
	* Must only be used for migrating legacy calendars.
	*
	* @param calendar The legacy calendar to create the subscription from.
	* @return A new [Subscription] that has the contents of [calendar].
	*/
	fun fromLegacyCalendar(calendar: LocalCalendar) =
	Subscription(
	id = calendar.id,
	url = Uri.parse(calendar.url ?: "https://invalid-url"),
	eTag = calendar.eTag,
	displayName = calendar.displayName ?: calendar.id.toString(),
	lastModified = calendar.lastModified,
	lastSync = calendar.lastSync,
	errorMessage = calendar.errorMessage,
	ignoreEmbeddedAlerts = calendar.ignoreEmbeddedAlerts ?: false,
	defaultAlarmMinutes = calendar.defaultAlarmMinutes,
	color = calendar.color
	)

[rfc2822]

I meant whether this adds an AUTOINCREMENT to the SQLite database or something like that. Then we would get a new database schema and would have to add an (auto-)migration.

[ArnyminerZ]

I meant whether this adds an AUTOINCREMENT to the SQLite database or something like that

Mmmh, I'm not sure, I'll look into it 😉

Edit: Yup, that's exactly what it does. It adds PRIMARY KEY AUTOINCREMENT

[ArnyminerZ]

@rfc2822 Is the version already released? I mean, if only us have it, maybe we can just erase data and not have to add a new version and enable automatic migration

[rfc2822]

True, it's not released yet, so this would work (we should do a manual extra test whether the release upgrade from the latest released version to now works smooth).

But shouldn't the change also update https://github.com/bitfireAT/icsx5/blob/dev/app/schemas/at.bitfire.icsdroid.db.AppDatabase/1.json?

[ArnyminerZ]

But shouldn't the change also update https://github.com/bitfireAT/icsx5/blob/dev/app/schemas/at.bitfire.icsdroid.db.AppDatabase/1.json

Yes, I was waiting for your confirmation 😄

[rfc2822]

Seems to work now!