-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum declared versions of dependencies #404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs cargo check on nightly requesting a build with minimum versions of dependencies declared as supported.
To minimal versions required to build most features (all other than core and rustc-dep-of-std) with --all-targets. Minimal required versions discovered by manual binsearch between minimum compatible version declared currently and the newest one available, and rerunning cargo check --all \ --features serde,arbitrary,bytemuck,std,example_generated \ --all-targets -Z minimal-versions to verify if it builds.
KodrAus
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dextero! This is a great improvement. The updates to CI are much appreciated.
mergify bot
pushed a commit
to andrzejressel/pulumi-wasm
that referenced
this pull request
Jun 25, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bitflags](https://togithub.com/bitflags/bitflags) | workspace.dependencies | minor | `2.5.0` -> `2.6.0` | --- ### Release Notes <details> <summary>bitflags/bitflags (bitflags)</summary> ### [`v2.6.0`](https://togithub.com/bitflags/bitflags/blob/HEAD/CHANGELOG.md#260) [Compare Source](https://togithub.com/bitflags/bitflags/compare/2.5.0...2.6.0) #### What's Changed - Sync CHANGELOG.md with github release notes by [@​dextero](https://togithub.com/dextero) in [bitflags/bitflags#402 - Update error messages and zerocopy by [@​KodrAus](https://togithub.com/KodrAus) in [bitflags/bitflags#403 - Bump minimum declared versions of dependencies by [@​dextero](https://togithub.com/dextero) in [bitflags/bitflags#404 - chore(deps): bump serde_derive and bytemuck versions by [@​joshka](https://togithub.com/joshka) in [bitflags/bitflags#405 - add OSFF Scorecard workflow by [@​KodrAus](https://togithub.com/KodrAus) in [bitflags/bitflags#396 - Update stderr messages by [@​KodrAus](https://togithub.com/KodrAus) in [bitflags/bitflags#408 - Fix typo by [@​waywardmonkeys](https://togithub.com/waywardmonkeys) in [bitflags/bitflags#410 - Allow specifying outer attributes in impl mode by [@​KodrAus](https://togithub.com/KodrAus) in [bitflags/bitflags#411 #### New Contributors - [@​dextero](https://togithub.com/dextero) made their first contribution in [bitflags/bitflags#402 - [@​joshka](https://togithub.com/joshka) made their first contribution in [bitflags/bitflags#405 - [@​waywardmonkeys](https://togithub.com/waywardmonkeys) made their first contribution in [bitflags/bitflags#410 **Full Changelog**: bitflags/bitflags@2.5.0...2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
kodiakhq bot
added a commit
to YuiYukihira/hanabAI
that referenced
this pull request
Jun 25, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bitflags](https://togithub.com/bitflags/bitflags) | dependencies | minor | `2.5.0` -> `2.6.0` | --- ### Release Notes <details> <summary>bitflags/bitflags (bitflags)</summary> ### [`v2.6.0`](https://togithub.com/bitflags/bitflags/blob/HEAD/CHANGELOG.md#260) [Compare Source](https://togithub.com/bitflags/bitflags/compare/2.5.0...2.6.0) #### What's Changed - Sync CHANGELOG.md with github release notes by [@​dextero](https://togithub.com/dextero) in [bitflags/bitflags#402 - Update error messages and zerocopy by [@​KodrAus](https://togithub.com/KodrAus) in [bitflags/bitflags#403 - Bump minimum declared versions of dependencies by [@​dextero](https://togithub.com/dextero) in [bitflags/bitflags#404 - chore(deps): bump serde_derive and bytemuck versions by [@​joshka](https://togithub.com/joshka) in [bitflags/bitflags#405 - add OSFF Scorecard workflow by [@​KodrAus](https://togithub.com/KodrAus) in [bitflags/bitflags#396 - Update stderr messages by [@​KodrAus](https://togithub.com/KodrAus) in [bitflags/bitflags#408 - Fix typo by [@​waywardmonkeys](https://togithub.com/waywardmonkeys) in [bitflags/bitflags#410 - Allow specifying outer attributes in impl mode by [@​KodrAus](https://togithub.com/KodrAus) in [bitflags/bitflags#411 #### New Contributors - [@​dextero](https://togithub.com/dextero) made their first contribution in [bitflags/bitflags#402 - [@​joshka](https://togithub.com/joshka) made their first contribution in [bitflags/bitflags#405 - [@​waywardmonkeys](https://togithub.com/waywardmonkeys) made their first contribution in [bitflags/bitflags#410 **Full Changelog**: bitflags/bitflags@2.5.0...2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/YuiYukihira/hanabAI). Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating
bitflags
dependency of another crate, I found out thatbitflags
' declared dependency versions are lower than needed to actually build the crate.This PR adds a GH workflow check inspired by the one from
gbm.rs
that attempts a build with the minimal compatible versions of all dependencies.Another commit in the PR bumps the declared versions to earliest ones I identified as working, to make the workflow pass.
The workflow builds all features other than
core
andrustc-dep-of-std
.cargo check --all --all-features --all-targets
failed for me on main with mentions of rustc/std, which successfully scared me away 😆 I have zero experience hacking on rustc/std so I don't even know how those are used.Hopefully this, or some parts of it can be useful as is 😄