Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a small top+bottom margin which text won't go into #2739

Closed
2 tasks done
jgclark opened this issue Feb 9, 2024 · 2 comments
Closed
2 tasks done

Allow a small top+bottom margin which text won't go into #2739

jgclark opened this issue Feb 9, 2024 · 2 comments
Labels
area/graphics Button drawing Enhancement New feature or request

Comments

@jgclark
Copy link

jgclark commented Feb 9, 2024

Is this a feature relevant to companion itself, and not a module?

  • I believe this to be a feature for companion, not a module

Is there an existing issue for this?

  • I have searched the existing issues

Describe the feature

This is the view of one of my frequently-used buttons.
IMG_2214

The first and last letters are slightly distorted by the edge of the plastic keycap. The only way to keep the top alignment and avoid this distortion is to reduce the size of the text.
However, if a tiny margin -- just 1 or 2 pixels -- could be configured to move the top alignment down by, and move the bottom alignment up by, then the distortion would go.

Usecases

No response

@Julusian Julusian added Enhancement New feature or request area/graphics Button drawing labels Feb 10, 2024
@dnmeid
Copy link
Member

dnmeid commented Feb 24, 2024

Hi @jgclarc,
thanks for your idea. The graphics system is currently under active development and will improve further. The main goal with our at this time limited control over text placement is to maximise the usable space. Currently we are using a 2 pixel offset from the top of the button when no topbar is shown. This is the best compromise between space utilization and not going into the edge of the key. We tested it with different surfaces and common wiewing angles.
If we now change this, it will break some existing button designs from many users.
In the future it is planned to give the users control over the bounding box of each text element and also allow for multiple elements on buttons. This functionality is already available in the renderer now but still needs to be exposed to the GUI in a useful way. So please be patient.

@dnmeid dnmeid closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
@jgclark
Copy link
Author

jgclark commented Feb 24, 2024

That's great news, @dnmeid. Thanks for the taking the time to explain this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphics Button drawing Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants