[BUG] Http GET CustomVariable does not get called

[smudge1977]

Is this a bug in companion itself or a module?

• I believe this to be a bug in companion

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

The API router does not seem to be allowing GET requests for a custom variable only POST to set it.

I an running version: 3.2.2 (3.2.2+6688-stable-7417d2a0)

Looking at main on GitHub:

companion/companion/lib/Service/HttpApi.js

Line 301 in d753d96

// custom variables

This should get called and log a debug entry in the log on trying a GET

companion/companion/lib/Service/HttpApi.js

Line 606 in d753d96

#customVariableGetValue = (req, res) => {

My test:

• Create myvar custom variable
• curl -X POST http://192.168.0.162:8888/api/custom-variable/myvar/value?value=99
  • Returns OK
  • UI Confirms changed value
  • Log has a debug entry
• curl -X GET http://192.168.0.162:8888/api/custom-variable/myvar/value
  • Returns a full html page
  • UI No change would be expected in the value
  • Log has no debug entry

I therefore think this is an issue with the GET been registered in the router at L301

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS:
- Browser:
- Companion Version:

Additional context

Think this might actually fix the above:
#2820

[smudge1977]

This merge is in latest Beta - I have now upgraded to 3.3.0 (3.3.0+6954-main-d753d965)

24.05.04 11:44:55 Service/HttpApi: Got HTTP custom variable get value name "myvar"
24.05.04 11:45:04 Service/HttpApi: Got HTTP custom variable set value name "myvar" to value "999"
24.05.04 11:45:07 Service/HttpApi: Got HTTP custom variable get value name "myvar"