-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide latest git commit SHA as an environmental variable #14
Comments
Hey @qnm. Thanks for this. One of the things we wanted to do with Linc and FABs is to get a directly traceable output from version control and to rebuild/redeploy as little as possible. One of those things is that we don't rebuild for every commit if we can detect that the And we can pass in the If you need a unique value whenever your JS changes, I would propose something like a hook in What do you think @geelen? |
@qnm I have added an environment variable called So you can use that for now if you want. It will just mean it will push out a change to product on every change to your repo, not just on every change to production code. Glen and I will have a proper chat next week on how to properly solve your problem. |
Thanks @evanderkoogh. I've added a Happy to provide input to any solution you come up with. The versioning value used by Rollbar does not have to correlate with git; git just happens to provide a useful proxy value for version! |
Hmm.. that is interesting? Let me have a check. I may have only released it to our own builds, not released it publicly. Will double-check tonight. And yeah I got Rollbar doesn't need to correspond with Git. The ideal solution AFAICT is a hook in |
Well @qnm, I am not saying I only released it internally, but I am also not saying I didn't only release it internally ;) Can you try the |
Closing this issue after creating one in the fab repository because we can solve it better over there. |
Looks like it's working now. Thanks Erwin! |
Is your feature request related to a problem? Please describe.
Configuration of Rollbar requires a version string (e.g. latest git commit SHA) to correctly identify source maps.
Describe the solution you'd like
I'd like a method to access the latest git commit SHA and include it in our codebase.
Describe alternatives you've considered
Can't think of another way to achieve this bar manual version bumps.
The text was updated successfully, but these errors were encountered: