Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Key Details for all other signers #4961

Closed
ASN-BitHyve opened this issue Jul 29, 2024 · 4 comments
Closed

Enable Key Details for all other signers #4961

ASN-BitHyve opened this issue Jul 29, 2024 · 4 comments
Assignees
@cakesoft-vaibhav
Labels
change request 🎛️ Non-dev task. To hold a lot of information across the issues in one place Status: fixed✅ It is fixed (PR merged)
Milestone
Sprint 38

Comments

@ASN-BitHyve
Copy link

We currently show Key Details only for Mobile Key. Going forward, once the user has added a key (Say a Coldcard or a Jade, etc.) The settings of that Key would show Key Details that the user can then give out to help their friends/clients with their Assisted Vaults.
@ASN-BitHyve ASN-BitHyve added change request 🎛️ Non-dev task. To hold a lot of information across the issues in one place Status: to-do 📋 Items not yet picked up labels Jul 29, 2024
@ASN-BitHyve ASN-BitHyve added this to the Sprint 35 milestone Jul 29, 2024
@Deveshshankar Deveshshankar modified the milestones: Sprint 35, Sprint 36 Aug 23, 2024
@cakesoft-utkarsh cakesoft-utkarsh removed their assignment Aug 26, 2024
@cakesoft-vaibhav cakesoft-vaibhav modified the milestones: Sprint 36, Sprint 37 Sep 3, 2024
@cakesoft-vaibhav cakesoft-vaibhav modified the milestones: Sprint 37, Sprint 38 Sep 27, 2024
@ben-kaufman
Copy link
Contributor

I beleive this is already done, and will be improved on in issue #5252

Can we close this one @cakesoft-utkarsh ?

@ASN-BitHyve ASN-BitHyve added Status: fixed✅ It is fixed (PR merged) and removed Status: to-do 📋 Items not yet picked up labels Oct 7, 2024
@cakesoft-utkarsh
Copy link
Member

I do not see an option "Key Details" to any signer other than Mobile Keys
App Version: 1.2.17(400)

@cakesoft-utkarsh cakesoft-utkarsh removed the Status: fixed✅ It is fixed (PR merged) label Oct 8, 2024
@ben-kaufman
Copy link
Contributor

Referring to this. I thought I saw it on all signers but rechecking I only see it on the mobile signer. But is that the screen you referred to in the issue?

image

@ben-kaufman ben-kaufman added Status: to-do 📋 Items not yet picked up Status: in-progress🛠️ Items picked up for work and removed Status: to-do 📋 Items not yet picked up labels Oct 9, 2024
@cakesoft-vaibhav cakesoft-vaibhav mentioned this issue Oct 10, 2024
Merged
@cakesoft-vaibhav cakesoft-vaibhav added Status: fixed✅ It is fixed (PR merged) and removed Status: in-progress🛠️ Items picked up for work labels Oct 11, 2024
@cakesoft-utkarsh
Copy link
Member

Verified on v 1.2.17(401)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cakesoft-vaibhav cakesoft-vaibhav

Labels
change request 🎛️ Non-dev task. To hold a lot of information across the issues in one place Status: fixed✅ It is fixed (PR merged)
Projects
None yet
Milestone
Sprint 38
Development

No branches or pull requests
5 participants
@ben-kaufman @cakesoft-utkarsh @ASN-BitHyve @Deveshshankar @cakesoft-vaibhav