F&F Issues.

[cakesoft-swati]

1.Unable to see the expiry timer on the F&F screen.

2.Unable to see the wallet name on F&F screen even after confirm the F&F request(by skipping the contact name) but ,we can see the wallet name if we click on that contact .

[CypherPoet]

Regarding Unable to see the expiry timer on the F&F screen., this is related to the comment I left here.

Any clarity about the logic required for displaying the timer would be really useful (@AliMeer @antuz123 @cakesoft-nikhita @Parsh )

[CypherPoet]

Regarding Unable to see the wallet name on F&F screen even after confirm the F&F request, is the issue that we want to show the wallet name even if other name properties exist? That is, does the wallet name take priority over everything else?

[antuz123]

Regarding Unable to see the wallet name on F&F screen even after confirm the F&F request, is the issue that we want to show the wallet name even if other name properties exist? That is, does the wallet name take priority over everything else?

Wallet name is used only when the Contact Name is not there (i.e. skip is used).

[antuz123]

If the requester uses 'skip', the app does not know the Contact name or the Wallet name. That is where we use the temp string. Which needs to be replaced when the Wallet name is received back.

[cakesoft-swati]

-Unable to see the changes on dev app version 1.3.1(161).
1.Unable to see the expiry timer on the F&F screen.
2.Unable to see the wallet name on F&F screen even after confirm the F&F request(by skipping the contact name) but ,we can see the wallet name if we click on that contact .

[CypherPoet]

Maybe I'm still not understanding how to reproduce this, but on the latest dev app version 1.3.1(161), the F&F screen appears to show the wallet name after confirming a request:

[cakesoft-swati]

-Still I'm not able to see the wallet name on F&F list after confirming the request.
-Tested on staging app version 1.3.1(162)

[cakesoft-swati]

I tried it by skipping the contact on both(sender and receivers) side.
I also tried it by skipping the contact on senders side.

[CypherPoet]

I think this needs to be fixed by making a few changes on the backend. The UI components that display these names are falling back to the wallet name if a displayedName doesn't exist. However, displayedName is being derived from the first and last name being set for a contact item -- which is being set to "F&F Request" for contacts where name information can't be found (instead of null).

See the discussion here for more details

[cakesoft-swati]

-Verified this issue on dev app version 1.3.1(164)