BITMAKER-3543 Stats module merging #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#204) * Added spiders endpoint to global stats and modified the stats serializers schema * Fixed issues with api generation, changed some schema responses and updated viewsets names * Added jobs action method to spiders viewset * Added the integration in frontend with the backend, disabled the expandable feature on the stats table * Disabling expandable row on stats table section * Fix issues mentioned on my reviewer's comments
* Rebase done & generating new API * Finished modals chart appendix content and added pagination for spiders * Changed the position of the expand icon to see the details modal * Changed spiders Ids for names to enhance UX, fixing issues with overview tab state variables on reloading * Fixing issue with default page in jobs and spiders endpoints * Generated new docs and fixing issue with notifications endpoint * Changing spider title tag
…enu (#160) * Call save_action method in views and serializers * Refactor Activity and Notification code * Changed Project ordering to use the name field * Fixed serializers and migrations. * Update serializers and views to correctly use activity and notification * Fix cronjob "run once" method --------- Co-authored-by: Raymond Negron <raymond1242@Raymonds-MacBook-Air.local> Co-authored-by: mgonnav <mateo@emegona.com>
* BITMAKER-1980: Save real-time stats in Redis (#144) * Retrieve job stats from Redis if the job is running * Catch Exception rather than PyMongo exceptions * Add unless-stopped restart policy to docker services * Save stats from Redis when job is manually stopped
raymond1242
reviewed
Jul 18, 2023
raymond1242
reviewed
Jul 18, 2023
raymond1242
reviewed
Jul 18, 2023
raymond1242
reviewed
Jul 18, 2023
raymond1242
reviewed
Jul 18, 2023
raymond1242
reviewed
Jul 18, 2023
raymond1242
suggested changes
Jul 18, 2023
webtaken
commented
Jul 19, 2023
webtaken
commented
Jul 19, 2023
Comment on lines
+126
to
+131
| **self.numerical_stats, | ||
| "jobs": {**self.jobs_stats}, | ||
| "pages": {**self.pages_stats}, | ||
| "status_codes": {**self.status_codes_stats}, | ||
| "logs": {**self.logs_stats}, | ||
| "coverage": {**self.coverage_stats}, |
There was a problem hiding this comment.
Now the initialization is shorter
raymond1242
reviewed
Jul 19, 2023
Comment on lines
+21
to
+23
| return Notification.objects.filter(user=self.request.user).order_by( | ||
| "-activity__created" | ||
| ) |
There was a problem hiding this comment.
This changes belong your PR?
raymond1242
reviewed
Jul 19, 2023
raymond1242
suggested changes
Jul 19, 2023
joaquingx
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review meetings and changing code for corrections if needed for the stats module branch since this is a big change.
Completion Criteria:
Stats module is merged.
Issue
Checklist before requesting a review