[bitnami/redis] Ability to rename redis service port name

[arianf]

Name and Version

bitnami/redis latest

What is the problem this feature will solve?

Our internal kube cluster has an odd requirement, it requires all service ports.name to match the ports.targetPort, I've filed something internally to hopefully get this constraint fixed (but due to the complexity of fixing it, it may take a lot of time, or never be resolved).

name: tcp-redis
targetPort: redis

charts/bitnami/redis/templates/master/service.yaml

Lines 47 to 58 in 7359f94

	ports:
	- name: tcp-redis
	port: {{ .Values.master.service.ports.redis }}
	targetPort: redis
	{{- if and (or (eq .Values.master.service.type "NodePort") (eq .Values.master.service.type "LoadBalancer")) .Values.master.service.nodePorts.redis}}
	nodePort: {{ .Values.master.service.nodePorts.redis}}
	{{- else if eq .Values.master.service.type "ClusterIP" }}
	nodePort: null
	{{- end }}
	{{- if .Values.master.service.extraPorts }}
	{{- include "common.tplvalues.render" (dict "value" .Values.master.service.extraPorts "context" $) | nindent 4 }}
	{{- end }}

What is the feature you are proposing to solve the problem?

It would be awesome, if ports.name or ports.targetPort name could also be configurable

What alternatives have you considered?

I've tried using .Values.master.service.extraPorts to add a port with matching name

service:
  extraPorts:
    - name: redis
      port: 6379
      protocol: TCP
      targetPort: redis

but that results with a duplicate key since the default config and the extraPorts config are using the same ports

spec.ports[1]: Duplicate value: core.ServicePort{Name:"", Protocol:"TCP", AppProtocol:(*string)(nil), Port:6379, TargetPort:intstr.IntOrString{Type:0, IntVal:0, StrVal:""}, NodePort:0}

[javsalgar]

Hi!

Thank you so much for reporting the issue. Would you like to submit a PR adding a value for the service name?

[github-actions]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[arianf]

Thank you @cwgthornton for submitting a fix for this!