Skip to content

Commit

Permalink
[bitnami/redis] Add option to change port name in master service
Browse files Browse the repository at this point in the history
Addresses bitnami#25228

Signed-off-by: Chris Thornton <cwgthornton@gmail.com>
  • Loading branch information
cwgthornton committed May 7, 2024
1 parent 1b4d6a1 commit 7d852e0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions bitnami/redis/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ helm install my-release --set master.persistence.existingClaim=PVC_NAME oci://RE
| `master.persistentVolumeClaimRetentionPolicy.whenScaled` | Volume retention behavior when the replica count of the StatefulSet is reduced | `Retain` |
| `master.persistentVolumeClaimRetentionPolicy.whenDeleted` | Volume retention behavior that applies when the StatefulSet is deleted | `Retain` |
| `master.service.type` | Redis&reg; master service type | `ClusterIP` |
| `master.service.portNames.redis` | Redis&reg; master service port name | `""` |
| `master.service.ports.redis` | Redis&reg; master service port | `6379` |
| `master.service.nodePorts.redis` | Node port for Redis&reg; master | `""` |
| `master.service.externalTrafficPolicy` | Redis&reg; master service external traffic policy | `Cluster` |
Expand Down
4 changes: 4 additions & 0 deletions bitnami/redis/templates/master/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ spec:
externalIPs: {{- include "common.tplvalues.render" (dict "value" .Values.master.service.externalIPs "context" $) | nindent 4 }}
{{- end }}
ports:
{{- if .Values.master.service.portNames.redis }}
- name: {{ .Values.master.service.portNames.redis }}
{{- else }}
- name: tcp-redis
{{- end }}
port: {{ .Values.master.service.ports.redis }}
targetPort: redis
{{- if and (or (eq .Values.master.service.type "NodePort") (eq .Values.master.service.type "LoadBalancer")) .Values.master.service.nodePorts.redis}}
Expand Down
4 changes: 4 additions & 0 deletions bitnami/redis/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,10 @@ master:
## @param master.service.type Redis&reg; master service type
##
type: ClusterIP
## @param master.service.portNames.redis Redis&reg; master service port name
##
portNames:
redis: ""
## @param master.service.ports.redis Redis&reg; master service port
##
ports:
Expand Down

0 comments on commit 7d852e0

Please sign in to comment.