Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/milvus] configure externalS3 tls settings #26111

Closed
chenraoCR opened this issue May 20, 2024 · 8 comments
Closed

[bitnami/milvus] configure externalS3 tls settings #26111

chenraoCR opened this issue May 20, 2024 · 8 comments
Assignees
Labels
feature-request milvus solved stale 15 days without activity triage Triage is needed

Comments

@chenraoCR
Copy link
Contributor

chenraoCR commented May 20, 2024

Name and Version

bitnami/milvus 7.0.5

What is the problem this feature will solve?

now the image docker.io/bitnami/milvus:2.4.2-debian-12-r1 that the helm chart bitnami/milvus:7.0.5 used supports to config mino tls client certs to connect minio server running with tls
https://github.com/milvus-io/milvus/blob/c6e2dd05fc89bbb4a6d9a851eddc9ceea7494abf/configs/milvus.yaml#L81
image
but now the bitnami/milvus helm chart cannot config externalS3 with tls certs
https://github.com/bitnami/charts/blob/bf03e1d210f3a2a2a13586014a5afd6756cc4b0a/bitnami/milvus/values.yaml#L5279C1-L5279C11

What is the feature you are proposing to solve the problem?

enbaled to config externalS3 tls certs
would like to commit a PR to solve this problem just like config etcd client tls certs
#20498

What alternatives have you considered?

we should enable milvus to connect external minio server running with tls with minio client certs

@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the feature request. I will forward it to the team, but as it is not a critical feature, we cannot guarantee an ETA. If you would like to contribute to a PR the team will review it, speeding up the process.

Copy link

github-actions bot commented Jun 5, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Jun 5, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
@chenraoCR
Copy link
Contributor Author

Hi!

Thank you so much for the feature request. I will forward it to the team, but as it is not a critical feature, we cannot guarantee an ETA. If you would like to contribute to a PR the team will review it, speeding up the process.

as the PR #26118 just merged, now will work on this feature

chenraoCR added a commit to chenraoCR/charts that referenced this issue Jun 10, 2024
chenraoCR added a commit to chenraoCR/charts that referenced this issue Jun 10, 2024
chenraoCR added a commit to chenraoCR/charts that referenced this issue Jun 10, 2024
@chenraoCR
Copy link
Contributor Author

@javsalgar Hi, i just commit a PR for this feature, so could you reopen it

@javsalgar javsalgar reopened this Jun 10, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the PR! The team will take a look

Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2024
chenraoCR added a commit to chenraoCR/charts that referenced this issue Jun 17, 2024
@chenraoCR
Copy link
Contributor Author

Hi!

Thank you so much for the PR! The team will take a look

hello, i have committed the PR #27068 for quite a long time, so how about the result?

chenraoCR added a commit to chenraoCR/charts that referenced this issue Jun 18, 2024
jotamartos pushed a commit that referenced this issue Jun 19, 2024
#27068)

* [bitnami/milvus] feat: config external S3 tls client certs settings (#26111)

Signed-off-by: Chen Rao <chenrao317328@163.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* commit suggestion

Signed-off-by: Chen Rao <chenrao317328@163.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Chen Rao <chenrao317328@163.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Chen Rao <45187622+chenraoCR@users.noreply.github.com>
Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request milvus solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

No branches or pull requests

4 participants