Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/milvus] feat: config external S3 tls client certs settings (… #27068

Merged
merged 5 commits into from
Jun 19, 2024
Merged

[bitnami/milvus] feat: config external S3 tls client certs settings (… #27068

merged 5 commits into from
Jun 19, 2024

Conversation

chenraoCR
Copy link
Contributor

@chenraoCR chenraoCR commented Jun 10, 2024 •
edited
Loading

Description of the change

config externalS3 tls settings

Benefits

allow users to config minio tls client certs when connect external minio running with tls

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added milvus triage Triage is needed labels Jun 10, 2024
@github-actions github-actions bot requested a review from javsalgar June 10, 2024 07:39
@chenraoCR chenraoCR force-pushed the feat/bitnami/milvus/26111 branch 2 times, most recently from e06de25 to 52e8c55 Compare June 10, 2024 07:51
@chenraoCR
Copy link
Contributor Author

this feature is just like #26110, please check and approve

@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Jun 10, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jun 10, 2024
@github-actions github-actions bot removed the request for review from javsalgar June 10, 2024 09:04
@github-actions github-actions bot requested a review from jotamartos June 10, 2024 09:04
@chenraoCR chenraoCR mentioned this pull request Jun 17, 2024
Closed
@bitnami-bot
Update CHANGELOG.md
b3bd1d1 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
jotamartos
jotamartos reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Can you take a look at my new comment? I didn't notice that in the first review. Thanks

bitnami/milvus/Chart.yaml Outdated Show resolved Hide resolved
bitnami/milvus/templates/_helpers.tpl Outdated Show resolved Hide resolved
chenraoCR and others added 3 commits June 18, 2024 17:24
@chenraoCR
commit suggestion
5ac1299 
Signed-off-by: Chen Rao <chenrao317328@163.com>
@chenraoCR
Merge branch 'main' into feat/bitnami/milvus/26111
d5f9768 
Signed-off-by: Chen Rao <45187622+chenraoCR@users.noreply.github.com>
@bitnami-bot
Update CHANGELOG.md
919f7b9 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@jotamartos jotamartos merged commit f8249bf into bitnami:main Jun 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos jotamartos approved these changes

Assignees

@jotamartos jotamartos

Labels
milvus solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenraoCR @jotamartos @javsalgar @bitnami-bot