Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mongodb] Change endpoint for metrics liveness and readiness probes #14573

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

aeber
Copy link
Contributor

@aeber aeber commented Jan 27, 2023

Fixes #14466

Signed-off-by: Anselm Eberhardt aeberhardt@dg-i.net

Description of the change

This switches the endpoints for readiness and liveness probes of the metrics container back to /.
The readiness and liveness probes currently query /metrics due to upstream changes in the mongodb-exporter v0.33.0: #11398

Benefits

The readiness and liveness probes of the metrics container should no longer run into timeouts when the response time of the current endpoint /metrics starts increasing due to the amount of data in the database.

Possible drawbacks

None.

Applicable issues

Additional information

Release v0.36.0 of the mongodb-exporter added a handler for / and this version is already distributed since the bitnami/mongodb chart v13.6.3.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Fixes bitnami#14466

Signed-off-by: Anselm Eberhardt <aeberhardt@dg-i.net>
@bitnami-bot bitnami-bot added this to Triage in Support Jan 27, 2023
@github-actions github-actions bot added the triage Triage is needed label Jan 27, 2023
@carrodher carrodher moved this from Triage to In progress in Support Jan 29, 2023
@carrodher carrodher added the verify Execute verification workflow for these changes label Jan 29, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Jan 29, 2023
@bitnami-bot bitnami-bot removed the request for review from carrodher January 29, 2023 17:39
Copy link
Contributor

@CeliaGMqrz CeliaGMqrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM

@CeliaGMqrz CeliaGMqrz merged commit 68039b1 into bitnami:main Jan 31, 2023
@bitnami-bot bitnami-bot moved this from In progress to Solved in Support Jan 31, 2023
@github-actions github-actions bot removed this from Solved in Support Feb 2, 2023
nik0811 pushed a commit to nik0811/charts that referenced this pull request Feb 4, 2023
…probes (bitnami#14573)

Fixes bitnami#14466

Signed-off-by: Anselm Eberhardt <aeberhardt@dg-i.net>
Signed-off-by: nikhil <nikhil811raj@gmail.com>
@zekena2
Copy link
Contributor

zekena2 commented Mar 28, 2023

This should have been a breaking change as the chart doesn't work anymore with older versions of the exporter. It's still a good change nevertheless.

@bitnami-bot bitnami-bot added this to Triage in Support Mar 28, 2023
@github-actions github-actions bot added triage Triage is needed and removed solved labels Mar 28, 2023
@carrodher carrodher moved this from Triage to Solved in Support Mar 28, 2023
@github-actions github-actions bot removed this from Solved in Support Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mongodb solved triage Triage is needed verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/mongodb] metrics readiness/liveness probe
4 participants