-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/mastodon] Move defaultConfig
and defaultSecretConfig
to default-configmap.yaml and default-secret.yaml respectively and add mastodon secret env vars
#19179
[bitnami/mastodon] Move defaultConfig
and defaultSecretConfig
to default-configmap.yaml and default-secret.yaml respectively and add mastodon secret env vars
#19179
Conversation
…and default-secret.yaml respectively Signed-off-by: jessebot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
…d none' conditional Signed-off-by: jessebot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
… passed into mastodon default secret Signed-off-by: jessebot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
…eady pass it in with the default-secret Signed-off-by: jessebot <jessebot@linux.com>
defaultConfig
and defaultSecretConfig
to default-configmap.yaml and default-secret.yaml respectivelydefaultConfig
and defaultSecretConfig
to default-configmap.yaml and default-secret.yaml respectively and add mastodon secret env vars
… it's no longer in use Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: JesseBot <jessebot@linux.com>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
…e existing secret parameter Signed-off-by: jessebot <jessebot@linux.com>
@fevisera no problem, and thanks for circling back around to this :) I've addressed and/or corrected everything. Happy to chat more about anything here or fix any other bugs you notice. |
Hi, Sorry for the delay. Kindly take a moment to check the comment I added regarding the chart version bump. Thanks. |
Signed-off-by: JesseBot <jessebot@linux.com>
@fevisera thanks again for reviewing! I've responded and I think this is finally ready to go :) |
Hi @jessebot, I'm having an issue running the cluster with the current modifications. It seems a
Could you please have a look at it? Also, I left some other comments related to some typos. Please, bump the version and I believe this would be all. Thanks! |
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Taking a look later today! By the way, when you find an easy fix, such as a typo or grammar issue on a PR, you can add Suggestions via the plus/minus button in the comment window on the file: then it automatically generates a suggestions block where you can put in your changes, such as this example: Which then shows up as something that can easily be clicked and added either in a batch to one large commit or in individual commits by the PR author, or if maintainer edits are turned on, by the reviewer. Example: You can read more here on how to apply suggestions if someone has made a suggestion on a PR you've submitted or edits by maintainers are turned on: This hasn't been a big problem for me on this PR or anything, I just wanted to give a friendly tip as it can help speed up the time it takes to collaborate in the future. |
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
Committed your smtp secret suggestion. Thanks for taking the time to test all of this 💙 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jessebot,
Thanks a lot for your tip! It is incredibly helpful, and I will definitely use it.
Also, thanks for reviewing the suggestions and applying the changes once again.
LGTM!
Description of the change
Moves the templated values for
defaultConfig
anddefaultSecretConfig
into default-configmap.yaml and default-secret.yaml respectively.Also makes the
adminUser
,adminEmail
, andsmtp.server
values optional, so that they can be provided via an external secret instead.Adds new
otpSecret
,secretBaseKey
,vapidPublicKey
andvapidPrivateKey
as parameters, as they did not have them before but are required as per mastodon secrets docs. I didn't see anything in the Bitnami helm chart or Bitnami container for mastodon that actually generates these though, so I put a note that you need to userake
to generate them.defaultConfig
anddefaultSecret
are currently gone, because you can still specify extra ConfigMap/Secret values, or alternative ConfigMap/Secret.Benefits
This allows users to use external tools that utilize go templating, e.g. Argo CD ApplicationSets using generators, without running into conflicts.
Possible drawbacks
Not sure there are any, as alternative or extra configuration can still be specified for both ConfigMap/Secrets.
There's enough mastodon parameters, perhaps it makes sense to have a
mastodon.secrets
param that we nest params likeotpSecret
,secretBaseKey
,vapidPublicKey
andvapidPrivateKey
under.Applicable issues
Additional information
Let me know if there's anything you want to change.
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm