[bitnami/mastodon] Move defaultConfig and defaultSecretConfig to default-configmap.yaml and default-secret.yaml respectively and add mastodon secret env vars

[jessebot]

Description of the change

Moves the templated values for defaultConfig and defaultSecretConfig into default-configmap.yaml and default-secret.yaml respectively.

Also makes the adminUser, adminEmail, and smtp.server values optional, so that they can be provided via an external secret instead.

Adds new otpSecret, secretBaseKey, vapidPublicKey and vapidPrivateKey as parameters, as they did not have them before but are required as per mastodon secrets docs. I didn't see anything in the Bitnami helm chart or Bitnami container for mastodon that actually generates these though, so I put a note that you need to use rake to generate them.

defaultConfig and defaultSecret are currently gone, because you can still specify extra ConfigMap/Secret values, or alternative ConfigMap/Secret.

Benefits

This allows users to use external tools that utilize go templating, e.g. Argo CD ApplicationSets using generators, without running into conflicts.

Possible drawbacks

Not sure there are any, as alternative or extra configuration can still be specified for both ConfigMap/Secrets.

There's enough mastodon parameters, perhaps it makes sense to have a mastodon.secrets param that we nest params like otpSecret, secretBaseKey, vapidPublicKey and vapidPrivateKey under.

Applicable issues

• partially fixes [bitnami/mastodon] Use of go templating inside of values.yaml for mastodon chart breaks Argo CD ApplicationSets #19173 (this still leaves the apache.vhostconfig because I couldn't figure out how to fix that issue)

Additional information

Let me know if there's anything you want to change.

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[github-actions]

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

[jessebot]

@fevisera no problem, and thanks for circling back around to this :) I've addressed and/or corrected everything. Happy to chat more about anything here or fix any other bugs you notice.

[fevisera]

Hi,

Sorry for the delay. Kindly take a moment to check the comment I added regarding the chart version bump.

Thanks.

[jessebot]

@fevisera thanks again for reviewing! I've responded and I think this is finally ready to go :)

[fevisera]

Hi @jessebot,

I'm having an issue running the cluster with the current modifications. It seems a data.server parameter is being missed in smtp-secret.yml. By adding the following line fixes to me:

 data:
   login: {{ .Values.smtp.login | b64enc | quote }}
   password: {{ .Values.smtp.password | b64enc | quote }}
+  server: {{ .Values.smtp.server | b64enc | quote }}
 {{- end }}

Could you please have a look at it?

Also, I left some other comments related to some typos.

Please, bump the version and I believe this would be all.

Thanks!

[jessebot]

Taking a look later today!

By the way, when you find an easy fix, such as a typo or grammar issue on a PR, you can add Suggestions via the plus/minus button in the comment window on the file:

then it automatically generates a suggestions block where you can put in your changes, such as this example:

Which then shows up as something that can easily be clicked and added either in a batch to one large commit or in individual commits by the PR author, or if maintainer edits are turned on, by the reviewer. Example:

You can read more here on how to apply suggestions if someone has made a suggestion on a PR you've submitted or edits by maintainers are turned on:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

This hasn't been a big problem for me on this PR or anything, I just wanted to give a friendly tip as it can help speed up the time it takes to collaborate in the future.

[jessebot]

Committed your smtp secret suggestion. Thanks for taking the time to test all of this 💙

[fevisera]

Hi @jessebot,

Thanks a lot for your tip! It is incredibly helpful, and I will definitely use it.

Also, thanks for reviewing the suggestions and applying the changes once again.

LGTM!