[bitnami/apisix] Fix disable tls on controlPlane and dataPlane #24600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Navea <j.navea.llorente@gmail.com>
Signed-off-by: Jorge Navea <j.navea.llorente@gmail.com>
|
Reviewing other open issues related with apisix, I've seen this one: #24482. This PR also fix this issue, |
jorgenll
changed the title
carrodher
added
verify
4 tasks
djjudas21
pushed a commit
to djjudas21/bitnami-charts
that referenced
this pull request
Apr 17, 2024
…mi#24600) * Fix disable tls on controlPlane Signed-off-by: Jorge Navea <j.navea.llorente@gmail.com> * Fix certs volumeMount when dataPlane tls is disabled Signed-off-by: Jorge Navea <j.navea.llorente@gmail.com> --------- Signed-off-by: Jorge Navea <j.navea.llorente@gmail.com> Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Honor the property
controlPlane.tls.enabledto generate or not the Secret apisix-control-plane-tls.Honor the property
dataPlane.tls.enabledwhen is set to false to don't mount the certificates on the data-plane.Benefits
Allows disable the tls on control-plane and data-plane.
Possible drawbacks
None IMO
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm