Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/apisix] bugfix: cert mounts when tls disabled #24482

Closed
wants to merge 1 commit into from

Conversation

grizzly-monkey
Copy link

Description of the change

When dataplane tls is disabled it complains for cert mount

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: jeEt <6825834+grizzly-monkey@users.noreply.github.com>
@github-actions github-actions bot added apisix triage Triage is needed labels Mar 15, 2024
@github-actions github-actions bot requested a review from javsalgar March 15, 2024 20:41
@grizzly-monkey grizzly-monkey changed the title fix: cert mounts when tls disabled [bitnami/apisix] fix: cert mounts when tls disabled Mar 15, 2024
@grizzly-monkey grizzly-monkey changed the title [bitnami/apisix] fix: cert mounts when tls disabled [bitnami/apisix] bugfix: cert mounts when tls disabled Mar 15, 2024
@carrodher
Copy link
Member

Thanks for your contribution! Could you please the chart version in the Chart.yaml file?

@migruiz4
Copy link
Member

Hi @grizzly-monkey,

I'm sorry for the inconvenience, but due to the lack of response, we have merged #24600 which also fixes this issue.

@migruiz4 migruiz4 closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants