-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/*] ci: 👷 Add tag and changelog support #25359
Changes from 5 commits
28a1203
9553899
f4a3cb4
e472bfe
e459d86
9d7b2be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ jobs: | |
with: | ||
path: charts | ||
fetch-depth: 2 # to be able to obtain files changed in the latest commit | ||
token: ${{ secrets.BITNAMI_BOT_TOKEN }} | ||
- id: get-chart | ||
name: 'Get modified charts' | ||
run: | | ||
|
@@ -59,6 +60,21 @@ jobs: | |
with: | ||
script: | | ||
core.setFailed('${{ steps.get-chart.outputs.error }}') | ||
- id: push-tag | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is the best place to push the tag, at this point the chart is not yet published and the repository is not updated with the new version. We can reach a situation where the tag is created and the chart is not published. We could leave this job as read-only and create a new job depending on the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AFAIK, several in several repositories release jobs get triggered when a tag is set, right? |
||
name: 'Push tag' | ||
if: ${{ steps.get-chart.outputs.result == 'ok' }} | ||
env: | ||
CHART: ${{ steps.get-chart.outputs.chart }} | ||
run: | | ||
cd charts | ||
# Get chart version and list of tags | ||
chart_version="$(yq e '.version' bitnami/${CHART}/Chart.yaml)" | ||
git fetch --tags | ||
# If the tag does not exist, create and push it (this allows re-executing the job) | ||
if ! git tag | grep ${CHART}/${chart_version}; then | ||
git tag ${CHART}/${chart_version} | ||
git push --tags | ||
fi | ||
vib-publish: | ||
runs-on: ubuntu-latest | ||
needs: get-chart | ||
|
@@ -107,7 +123,7 @@ jobs: | |
curl -SsLfO "https://get.helm.sh/${HELM_TARBALL}" && sudo tar xf "$HELM_TARBALL" --strip-components 1 -C /usr/local/bin | ||
- id: update-index | ||
name: Fetch chart and update index | ||
env: | ||
env: | ||
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_PUBLISH_ACCESS_KEY_ID }} | ||
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_PUBLISH_SECRET_ACCESS_KEY }} | ||
AWS_ASSUME_ROLE_ARN: ${{ secrets.AWS_PUBLISH_ROLE_ARN }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,3 +23,5 @@ | |
.vscode/ | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,3 +23,5 @@ | |
.vscode/ | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,3 +22,5 @@ | |
.vscode/ | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,3 +22,5 @@ | |
.vscode/ | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,3 +23,5 @@ | |
.vscode/ | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,3 +19,5 @@ | |
.project | ||
.idea/ | ||
*.tmproj | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,3 +24,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,5 @@ | |
*.tmproj | ||
# img folder | ||
img/ | ||
# Changelog | ||
CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
BITNAMI_BOT_TOKEN
required? This could trigger other workflows, is that expected? If you need write access to the repository you can change thepermissions
section int the job definition.charts/.github/workflows/cd-pipeline.yml
Lines 18 to 19 in ef3fea4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need write access to push the tags