Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] adding a way to pass annotations to provisioning Pods #6585

Merged
merged 1 commit into from Jun 8, 2021
Merged

[bitnami/kafka] adding a way to pass annotations to provisioning Pods #6585

merged 1 commit into from Jun 8, 2021

Conversation

pdemagny
Copy link
Contributor

@pdemagny pdemagny commented Jun 7, 2021

Description of the change

Hi,

First of all, thank you for sharing and maintaining these charts !
I propose this humble contribution to address a minor issue i ran into.

If you have Istio in your cluster, the provisionning Job never ends due to the istio sidecar running forever.
#5835 (comment) propose a way to keep the Pod in the Mesh but kill the proxy at the end of the Job.
This PR adds optional Pod annotations to the provisioning Pods.
It allows, for example, to completely disable Istio for the provisioning Job by passing the sidecar.istio.io/inject: "false" annotation.

Benefits

  • Provides more control over the Kubernetes resources created by this chart.
  • Allow a wider variety of use cases for Istio Mesh users.

Possible drawbacks

None that i can think of.

Applicable issues

Related to #5835

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/<name_of_the_chart>])

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Great PR! Please pay attention to the following items before merging:

Files matching bitnami/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files

bitnami/kafka/Chart.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@marcosbc marcosbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marcosbc marcosbc merged commit d2c2576 into bitnami:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants