Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/kafka] adding a way to pass annotations to provisioning Pods #6585

Merged
merged 1 commit into from
Jun 8, 2021
Merged

[bitnami/kafka] adding a way to pass annotations to provisioning Pods #6585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitnami/kafka/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ name: kafka
sources:
- https://github.com/bitnami/bitnami-docker-kafka
- https://kafka.apache.org/
version: 12.19.2
version: 12.20.0
1 change: 1 addition & 0 deletions bitnami/kafka/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ The following tables lists the configurable parameters of the Kafka chart and th
| `provisioning.image` | Kafka provisioning Job image | `Check values.yaml file` |
| `provisioning.numPartitions` | Default number of partitions for topics when unspecified. | 1 |
| `provisioning.replicationFactor` | Default replication factor for topics when unspecified. | 1 |
| `provisioning.podAnnotations` | Provisioning Pod annotations. | `{}` (evaluated as a template) |
| `provisioning.resources` | Kafka provisioning Job resources | `Check values.yaml file` |
| `provisioning.topics` | Kafka provisioning topics | `[]` |
| `provisioning.schedulerName` | Name of the k8s scheduler (other than default) for kafka provisioning | `nil` |
Expand Down
3 changes: 3 additions & 0 deletions bitnami/kafka/templates/kafka-provisioning.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ spec:
{{- include "common.tplvalues.render" (dict "value" .Values.podLabels "context" $) | nindent 8 }}
{{- end }}
annotations:
{{- if .Values.provisioning.podAnnotations }}
{{- include "common.tplvalues.render" (dict "value" .Values.provisioning.podAnnotations "context" $) | nindent 8 }}
{{- end }}
spec:
{{- include "kafka.imagePullSecrets" . | nindent 6 }}
{{- if .Values.provisioning.schedulerName }}
Expand Down
2 changes: 2 additions & 0 deletions bitnami/kafka/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,6 +893,8 @@ provisioning:
##
# schedulerName:

podAnnotations: {}

resources:
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
Expand Down