Map define warn

[moschel]

related to https://forum.javascriptmvc.com/topic/can-route-map-working-with-arrays

I've seen a few times that people forget to add the define plugin and it fails silently. This is an attempt to add a warning so its obvious right away.

[moschel]

@daffl this is failing jshint:

[L248:C17] W098: 'MapClass' is defined but never used.
    var MapClass = can.Map.extend({

In this case, that's intended. How can I ignore that for this test?

[DVSoftware]

@moschel surround it with

/* jshint ignore:start */
your code
/* jshint ignore:end */

[daffl]

Why not take it out? The test should still do what it is supposed to without the var MapClass.

[justinbmeyer]

Why would you check if prop === define on every iteration of this loop? Can you you just check if "prop" in this.prototype outside this loop.

Also, using .toString() isn't supported everywhere ... is this the best way of checking if the define plugin is loaded?

[justinbmeyer]

I'm not sure we should be doing this. There are lots of plugins and we don't warn about each one.

[moschel]

@daffl that test wouldn't work without a map definition

@justinbmeyer lately we've been adding warnings for "silent failure" type things, like wrong property names in a mustache template. Most plugins don't fail silently, they define a function that gets called and user code throws an error without it, or something similar. This fails silently.

I added a better check, the problem was there is nothing special defined in the define plugin that could be inspected for feature detection code, so I changed the function stub. Do you see any reason this could be bad?

[moschel]

did this off of minor, so closing it and opening another