Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings for map/define #1054

Merged
merged 1 commit into from Jun 10, 2014
Merged

Warnings for map/define #1054

merged 1 commit into from Jun 10, 2014

Conversation

moschel
Copy link
Contributor

@moschel moschel commented Jun 5, 2014

fixes #1041

Adds 2 warnings:

  1. when someone tries to add a define property but haven't included the define plugin
  2. when someone tries to add define on static props, not prototype props

@moschel
Copy link
Contributor Author

moschel commented Jun 5, 2014

This is the same as #1041 but on master, not minor

@daffl daffl added this to the 2.1.2 milestone Jun 6, 2014
daffl added a commit that referenced this pull request Jun 10, 2014
@daffl
Merge pull request #1054 from bitovi/map-define-warn-master
73a7c98 
Warnings for map/define
@daffl daffl merged commit 73a7c98 into master Jun 10, 2014
@daffl daffl deleted the map-define-warn-master branch June 10, 2014 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moschel @daffl