#1521 define map properties in the same order they're defined

[moschel]

fixes #1521 by enforcing define property ordering

@justinbmeyer and I discussed this afternoon and the root cause was calling the getter for a property that references a default value, but it hadn't been set yet, even though it is before the getter in the property list.

[daffl]

It looks like some tests (AMD, distributables) are failing legitimately. I am also not sure if this is the right fix. The order of keys in objects is not determined and not necessarily the same as it was defined. #1521 is a a regression so it must have been introduced somewhere else.

[justinbmeyer]

In practice and in all commonly used versions of JS order is preserved.

Sent from my iPhone

On Mar 17, 2015, at 9:17 AM, David Luecke notifications@github.com wrote:

It looks like some tests (AMD, distributables) are failing legitimately. I am also not sure if this is the right fix. The order of keys in objects is not determined and not necessarily the same as it was defined. #1521 is a a regression so it must have been introduced somewhere else.

—
Reply to this email directly or view it on GitHub.

[moschel]

This is still failing but I'm not sure why, the travis logs don't say which tests failed

[justinbmeyer]

It's possible Travis / phantom does not respect order?

Sent from my iPhone

On Mar 17, 2015, at 9:45 PM, Brian Moschel notifications@github.com wrote:

This is still failing but I'm not sure why, the travis logs don't say which tests failed

—
Reply to this email directly or view it on GitHub.

[daffl]

The reasons for the tests failing is that the attributes plugin does not play very well with define. I made the test conditional since we probably will remove the old attributes plugin - or at least take it out of this repository.