New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1521 define map properties in the same order they're defined #1526

Merged
merged 2 commits into from Mar 20, 2015

Conversation

Projects
None yet
3 participants
@moschel
Contributor

moschel commented Mar 17, 2015

fixes #1521 by enforcing define property ordering

@justinbmeyer and I discussed this afternoon and the root cause was calling the getter for a property that references a default value, but it hadn't been set yet, even though it is before the getter in the property list.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 17, 2015

Contributor

It looks like some tests (AMD, distributables) are failing legitimately. I am also not sure if this is the right fix. The order of keys in objects is not determined and not necessarily the same as it was defined. #1521 is a a regression so it must have been introduced somewhere else.

Contributor

daffl commented Mar 17, 2015

It looks like some tests (AMD, distributables) are failing legitimately. I am also not sure if this is the right fix. The order of keys in objects is not determined and not necessarily the same as it was defined. #1521 is a a regression so it must have been introduced somewhere else.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Mar 18, 2015

Contributor

In practice and in all commonly used versions of JS order is preserved.

Sent from my iPhone

On Mar 17, 2015, at 9:17 AM, David Luecke notifications@github.com wrote:

It looks like some tests (AMD, distributables) are failing legitimately. I am also not sure if this is the right fix. The order of keys in objects is not determined and not necessarily the same as it was defined. #1521 is a a regression so it must have been introduced somewhere else.


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Mar 18, 2015

In practice and in all commonly used versions of JS order is preserved.

Sent from my iPhone

On Mar 17, 2015, at 9:17 AM, David Luecke notifications@github.com wrote:

It looks like some tests (AMD, distributables) are failing legitimately. I am also not sure if this is the right fix. The order of keys in objects is not determined and not necessarily the same as it was defined. #1521 is a a regression so it must have been introduced somewhere else.


Reply to this email directly or view it on GitHub.

@moschel

This comment has been minimized.

Show comment
Hide comment
@moschel

moschel Mar 18, 2015

Contributor

This is still failing but I'm not sure why, the travis logs don't say which tests failed

Contributor

moschel commented Mar 18, 2015

This is still failing but I'm not sure why, the travis logs don't say which tests failed

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Mar 18, 2015

Contributor

It's possible Travis / phantom does not respect order?

Sent from my iPhone

On Mar 17, 2015, at 9:45 PM, Brian Moschel notifications@github.com wrote:

This is still failing but I'm not sure why, the travis logs don't say which tests failed


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Mar 18, 2015

It's possible Travis / phantom does not respect order?

Sent from my iPhone

On Mar 17, 2015, at 9:45 PM, Brian Moschel notifications@github.com wrote:

This is still failing but I'm not sure why, the travis logs don't say which tests failed


Reply to this email directly or view it on GitHub.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 20, 2015

Contributor

The reasons for the tests failing is that the attributes plugin does not play very well with define. I made the test conditional since we probably will remove the old attributes plugin - or at least take it out of this repository.

Contributor

daffl commented Mar 20, 2015

The reasons for the tests failing is that the attributes plugin does not play very well with define. I made the test conditional since we probably will remove the old attributes plugin - or at least take it out of this repository.

daffl added a commit that referenced this pull request Mar 20, 2015

Merge pull request #1526 from bitovi/sorted-define
#1521 define map properties in the same order they're defined

@daffl daffl merged commit 61ebdb6 into master Mar 20, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the sorted-define branch Mar 20, 2015

@daffl daffl added this to the 2.2.1 milestone Mar 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment