Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make $#domManip patch jq2.0-compatible #526

Merged
merged 1 commit into from
Nov 5, 2013
Merged

Make $#domManip patch jq2.0-compatible #526

merged 1 commit into from
Nov 5, 2013

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Nov 2, 2013

This patch makes the inserted event compatible with both jquery 1.9.1 and >2.0.0.
The only relevant difference between the two versions is that >2.0.0 expects arguments[1] to be the callback, instead of arguments[2]. The other arguments can be passed through normally.

@wclr
Copy link
Contributor

wclr commented Nov 2, 2013

+1

@justinbmeyer
Copy link
Contributor

We need to setup grunt to test different versions of jQuery.

You'll probably have to add other configurations to builder.json like "jquery-1.9" and "jquery-2.0" that load different things for "jquery/jquery.js".

And, the gruntfile needs to be setup to test the different pages. The qunit object should probably be built from builder.json.

@daffl
Copy link
Contributor

daffl commented Nov 5, 2013

I can work on that. We should just remove all those checked in libraries and use Bower for different dependencies. That will get our Codeclimate up quite a bit, too.

daffl added a commit that referenced this pull request Nov 5, 2013
Make $#domManip patch jq2.0-compatible
@daffl daffl merged commit db8512d into canjs:master Nov 5, 2013
Amechi101 pushed a commit that referenced this pull request Jun 6, 2019
chasenlehara pushed a commit that referenced this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants