-
Notifications
You must be signed in to change notification settings - Fork 421
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make $#domManip patch jq2.0-compatible
- Loading branch information
Josh Marchán
committed
Nov 2, 2013
1 parent
cec0679
commit 60dbf49
Showing
1 changed file
with
17 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -116,16 +116,23 @@ steal('jquery', 'can/util/can.js', 'can/util/array/each.js', "can/util/inserted" | |
|
||
var oldDomManip = $.fn.domManip; | ||
|
||
$.fn.domManip = function(args, table, callback){ | ||
return oldDomManip.call(this,args,table, function(elem){ | ||
if(elem.nodeType === 11){ | ||
var elems = can.makeArray(elem.childNodes); | ||
} | ||
var ret = callback.apply(this, arguments); | ||
can.inserted(elems? elems : [elem]) | ||
return ret | ||
}) | ||
} | ||
$.fn.domManip = function(){ | ||
var args = can.makeArray(arguments), | ||
isNew$ = $.fn.jquery >= "2.0.0", | ||
This comment has been minimized.
Sorry, something went wrong. |
||
cbIndex = isNew$ ? 1 : 2, | ||
callback = args[cbIndex]; | ||
|
||
args[cbIndex] = function(elem) { | ||
var isFragment = elem.nodeType === Node.DOCUMENT_FRAGMENT_NODE, | ||
This comment has been minimized.
Sorry, something went wrong.
imjoshdean
Contributor
|
||
targets = isFragment ? can.makeArray(elem.childNodes) : [elem], | ||
ret = callback.apply(this, arguments); | ||
can.inserted(targets); | ||
return ret; | ||
}; | ||
|
||
return oldDomManip.apply(this, args); | ||
}; | ||
|
||
$.event.special.inserted = {}; | ||
$.event.special.removed = {}; | ||
|
||
|
1 comment
on commit 60dbf49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not have been added without tests. Also, no inline docs. Please make sure the code you submit to master has that quality level.
This could likely have been pre-calculated instead of running each time.