Refactor network configuration for messages #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @constructor | ||
| */ | ||
| function Message(options) { | ||
| this.command = options.command; | ||
| this.magicNumber = options.magicNumber; | ||
| this.network = options.network || Networks.defaultNetwork; |
There was a problem hiding this comment.
The default should always be set in Messages factory, I don't think it needs to be set here if it's not defined.
|
Tested. Should make things more clear. |
| @@ -36,10 +36,10 @@ For advanced usage, you can also customize which constructor is used for Block a | |||
| var messages = new Messages({Block: MyBlock, Transaction: MyTransaction}); | |||
| ``` | |||
|
|
|||
| And additionally custom network magic: | |||
| And additionally custom network: | |||
There was a problem hiding this comment.
Existing typo: "And additionally a custom network:"
braydonf
pushed a commit
that referenced
this pull request
Apr 24, 2015
Refactor network configuration for messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to use bitcore-p2p with custom networks (such as testnet, or others)