SIGHASH_ANYONECANPAY should be 0x80 in ScriptInterpreter

[ethers]

It should be 0x80 to match https://github.com/bitcoin/bitcoin/blob/master/src/script.h#L183 as well as what's in lib/Transaction.js. (unifying these constants in ScriptInterpreter and Transaction can be done in another issue)

Also, SIGHASH_ANYONECANPAY is untested. eg set SIGHASH_ANYONECANPAY to 0 and all the tests still pass.

[ryanxcharles]

Good catch. Someone mis-typed 80 for 0x80 in ScriptInterpreter.

[maraoz]

I remember changing it in Transaction.js because it was wrong and I never guessed it could be repeated in other place. We should definitely unify the constants. Maybe it makes more sense to have a separate protocol constants file (constants.js)?

On Tue, Jul 15, 2014 at 3:53 PM, Ryan X. Charles notifications@github.com
wrote:

Good catch. Someone mis-typed 80 for 0x80 in ScriptInterpreter. We also have the same constant in Transaction.js, but it is defined correctly there.

Reply to this email directly or view it on GitHub:
#424 (comment)

[ryanxcharles]

Yeah I thought I had remembered seeing this issue before. I'm open to putting all the constants in a single file. However, that does mean that if you need just one constant, you would have to include the entire list, which is undesirable for the browser.

[ethers]

IMO ScriptInterpreter is fine for these constants.
PR looks good.

[I should have made these changes since I missed that SIGHASH_ANYONECANPAY is indeed tested by Transaction tests (instead of ScriptInterpreter tests)].