Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bitcore-Node][BWS] Fix for wallet balance issue #3493

Merged
merged 3 commits into from
Dec 5, 2022
Merged

[Bitcore-Node][BWS] Fix for wallet balance issue #3493

merged 3 commits into from
Dec 5, 2022

Conversation

escottalexander
Copy link
Contributor

It now checks spentHeight instead of spentTxid in BWS.
In Bitcore-Node when a mempool tx is invalidated, in addition to resetting the coin to unspent status we set the spentTxid to ''.

@snyk-bot snyk-bot mentioned this pull request Nov 21, 2022
Open
@adamlaska adamlaska mentioned this pull request Nov 21, 2022
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Nov 22, 2022
Open
@baby636 baby636 mentioned this pull request Nov 22, 2022
Open
@adamlaska adamlaska mentioned this pull request Nov 22, 2022
Open
@baby636 baby636 mentioned this pull request Nov 22, 2022
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Nov 22, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 22, 2022
Open
@cballou cballou mentioned this pull request Nov 22, 2022
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Nov 22, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 22, 2022
Open
kajoseph
kajoseph approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@kajoseph kajoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kajoseph kajoseph merged commit 4d92d0a into bitpay:master Dec 5, 2022
@adamlaska adamlaska mentioned this pull request Nov 26, 2023
Open
@Manny27nyc Manny27nyc mentioned this pull request Dec 19, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Dec 19, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 19, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Dec 19, 2023
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Dec 19, 2023
Open
@BitcoinOutput BitcoinOutput mentioned this pull request Dec 19, 2023
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Dec 19, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 20, 2023
Open
@baby636 baby636 mentioned this pull request Dec 20, 2023
Open
@qmutz qmutz mentioned this pull request Dec 20, 2023
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Apr 15, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Apr 15, 2024
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Apr 15, 2024
Open
@cballou cballou mentioned this pull request Apr 15, 2024
Open
@Manny27nyc Manny27nyc mentioned this pull request Apr 15, 2024
Open
@adamlaska adamlaska mentioned this pull request Apr 15, 2024
Open
@Megoy-Tambayan Megoy-Tambayan mentioned this pull request Apr 15, 2024
Open
@Rose2161 Rose2161 mentioned this pull request Apr 15, 2024
Open
@BitcoinOutput BitcoinOutput mentioned this pull request Apr 16, 2024
Open
@baby636 baby636 mentioned this pull request Apr 16, 2024
Open
@qmutz qmutz mentioned this pull request Apr 17, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajoseph kajoseph kajoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escottalexander @kajoseph