Move TransactionBuilder.scriptForAddress to Address.getScriptPubKey. Resolves #373

[manan19]

Move TransactionBuilder.scriptForAddress to Address.getScriptPubKey
fixes #373

[coveralls]

Coverage remained the same when pulling 1e79ce7 on manan19:move-scriptForAddress into 83aada8 on bitpay:master.

[coveralls]

Coverage remained the same when pulling b6ff29d on manan19:move-scriptForAddress into 83aada8 on bitpay:master.

[maraoz]

Good work. I like what you did, but my idea of #373 was to have an instance method for Address, so you could do:

var a = new Address('1FpjY2BzdYKw8bP1LNxat4ddhkyhL52uLU');
console.log(a.getScriptPubKey());

I can see the usefulness of having a static/class method, though, as you don't need to create an instance if you only have the address string. Thoughts?

[ryanxcharles]

Agreed with @maraoz . Seems the more appropriate way to do this is an instance method.

[manan19]

Haha, I initially put in a pull request with an instance method and then modified it.
I'll change it back, should be easy.

[manan19]

Pushed the changes.

[coveralls]

Coverage increased (+0.02%) when pulling d83fc6e on manan19:move-scriptForAddress into 6ac5154 on bitpay:master.