Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TransactionBuilder.scriptForAddress to Address.js #373

Closed
maraoz opened this issue Jun 9, 2014 · 0 comments · Fixed by #384
Closed

Move TransactionBuilder.scriptForAddress to Address.js #373

maraoz opened this issue Jun 9, 2014 · 0 comments · Fixed by #384

Comments

@maraoz
Copy link
Contributor

maraoz commented Jun 9, 2014

It's a address to script conversion, so it should be in Address.

It can also change name to "Address#getScriptPubKey"
Ref: https://github.com/bitpay/bitcore/blob/master/lib/TransactionBuilder.js#L123
@manan19 manan19 mentioned this issue Jun 19, 2014
Merged
ryanxcharles pushed a commit that referenced this issue Jun 20, 2014
Merge pull request #384 from manan19/move-scriptForAddress
a727028 
Move TransactionBuilder.scriptForAddress to Address.getScriptPubKey. Resolves #373
micahriggan pushed a commit to micahriggan/bitcore that referenced this issue Dec 27, 2018
@matiu
Merge pull request bitpay#373 from matiu/ver-024
e8d60c9 
bump version, update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move TransactionBuilder.scriptForAddress to Address.getScriptPubKey. Resolves #373
1 participant
@maraoz