Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/encryption #196

Merged
merged 2 commits into from
Apr 28, 2014
Merged

Feature/encryption #196

merged 2 commits into from
Apr 28, 2014

Conversation

matiu
Copy link
Collaborator

@matiu matiu commented Apr 25, 2014

  • adds symmetric encryption (AES) to peer communication, using the other's peer public key as passphrase.
  • this prevents 3rd party eye dropping attack during wallet creation

This will be modified to asymmetric EC encryption once bitpay/bitcore#287 gets implemented on bitcore. By doing this, 1-to-1 p2p communications will be protected from other peers in the wallet, also.

colkito pushed a commit that referenced this pull request Apr 28, 2014
Merge pull request #196 from matiu/feature/encryption
380014a 
Feature/encryption
@colkito colkito merged commit 380014a into bitpay:master Apr 28, 2014
bitjson pushed a commit that referenced this pull request Oct 25, 2016
@cmgustavo
Merge pull request #196 from gabrielbazan7/fix/backupNeeded
49492a2 
fixes - hide tabs in backup flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiu @colkito