Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apps decompiler 1.0.0 #2865

Closed
wants to merge 3 commits into from
Closed

Apps decompiler 1.0.0 #2865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1b1f14
apps-decompiler 1.0.0
imranMnts Jan 21, 2021
eab94fd
add app icon
imranMnts Jan 21, 2021
ce10129
update
imranMnts Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
79 changes: 79 additions & 0 deletions steps/apps-decompiler/1.0.0/step.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
title: Mobile apps decompiler
summary: |
Decompile mobile APK and/or IPA to look inside
description: |
Decompile mobile APK and/or IPA to look inside

### Troubleshooting

- Be aware, you have to launch this step after the compilation step ("Android Build" for android, "Xcode Archive" for iOS)
- Launch "Deploy to Bitrise.io" step after this one to deploy report files to artifacts
website: https://github.com/odemolliens/bitrise-step-apps-decompiler
source_code_url: https://github.com/odemolliens/bitrise-step-apps-decompiler
support_url: https://github.com/odemolliens/bitrise-step-apps-decompiler/issues
published_at: 2021-01-21T12:04:43.593758+01:00
source:
git: https://github.com/odemolliens/bitrise-step-apps-decompiler.git
commit: 9d55d0cb5e332c4be62952c78329efbf8dd5f8e8
host_os_tags:
- osx-10.10
- ubuntu-16.04
project_type_tags:
- ios
- android
- react-native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other multi-platform ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on
https://github.com/bitrise-steplib/steps-xcode-archive/blob/master/step.yml
and
https://github.com/bitrise-steplib/steps-gradle-runner/blob/master/step.yml

which generate the APK and IPA
I don't test it with the others so I don't know if it can be used, so to be sure, I didn't add them.

- flutter
type_tags:
- utility
toolkit:
bash:
entry_file: step.sh
deps:
brew:
- name: jq
- name: apktool
is_requires_admin_user: false
is_always_run: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want the is_always_run field to be true?

is_always_run: if true the step will be executed even if a previous step failed during the build. 
Default is false.
- if type_tags is 'notification' this needs to be true

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary for this step :)

is_skippable: false
inputs:
- decompile_android: "yes"
opts:
is_expand: true
is_required: true
summary: Do you want decompile Android APK?
title: Decompile Android APK
value_options:
- "yes"
- "no"
- decompile_ios: "yes"
opts:
is_expand: true
is_required: true
summary: Do you want decompile iOS IPA?
title: Decompile iOS IPA
value_options:
- "yes"
- "no"
- opts:
description: |
You can use the artifacts from another bitrise build of the same project.
If you launch this step on the build where you launched Android build step eg. you don't have to set this key
is_expand: true
is_required: false
summary: Build slug of the build where you have the APK/IPA into artifacts
title: External Build slug
outside_build_slug: null
- android_apk_path: $BITRISE_APK_PATH
opts:
description: |
If you use this step in the same build where you generated the APK
is_expand: true
is_required: true
title: APK path
- ios_ipa_path: $BITRISE_IPA_PATH
opts:
description: |
If you use this step in the same build where you generated the IPA
Copy link
Contributor

@koral-- koral-- Jan 21, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording sounds strange. Is it a calque?
It's just an IPA path? What is the point of "If"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user will be able to launch this step from the step where he will generate his IPA
In that case, we need to have the path to get it. Per default XCode archive step save the path in $BITRISE_IPA_PATH but to be able to support the case where the user deployed it in another path we have this input.

In the case where the user launches this step outside of the step where he will generate the IPA (eg. to launch a build specifically for quality to not mix it with deploy build) also we don't need to have this path because it will download the IPA directly from the deployment builds artifacts with outside_build_slug input

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so you should somehow express it in a condensed way for a valid description.

is_expand: true
is_required: true
title: IPA path
1 change: 1 addition & 0 deletions steps/apps-decompiler/assets/icon.svg
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions steps/apps-decompiler/step-info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
maintainer: community