Apps decompiler 1.0.0 #2865
Apps decompiler 1.0.0 #2865
Conversation
| - ios_ipa_path: $BITRISE_IPA_PATH | ||
| opts: | ||
| description: | | ||
| If you use this step in the same build where you generated the IPA |
There was a problem hiding this comment.
The wording sounds strange. Is it a calque?
It's just an IPA path? What is the point of "If"?
There was a problem hiding this comment.
The user will be able to launch this step from the step where he will generate his IPA
In that case, we need to have the path to get it. Per default XCode archive step save the path in $BITRISE_IPA_PATH but to be able to support the case where the user deployed it in another path we have this input.
In the case where the user launches this step outside of the step where he will generate the IPA (eg. to launch a build specifically for quality to not mix it with deploy build) also we don't need to have this path because it will download the IPA directly from the deployment builds artifacts with outside_build_slug input
There was a problem hiding this comment.
OK, so you should somehow express it in a condensed way for a valid description.
| project_type_tags: | ||
| - ios | ||
| - android | ||
| - react-native |
There was a problem hiding this comment.
What about other multi-platform ones?
There was a problem hiding this comment.
Based on
https://github.com/bitrise-steplib/steps-xcode-archive/blob/master/step.yml
and
https://github.com/bitrise-steplib/steps-gradle-runner/blob/master/step.yml
which generate the APK and IPA
I don't test it with the others so I don't know if it can be used, so to be sure, I didn't add them.
| - name: jq | ||
| - name: apktool | ||
| is_requires_admin_user: false | ||
| is_always_run: true |
There was a problem hiding this comment.
Do you want the is_always_run field to be true?
is_always_run: if true the step will be executed even if a previous step failed during the build.
Default is false.
- if type_tags is 'notification' this needs to be true
There was a problem hiding this comment.
I think it is not necessary for this step :)
|
Continues in #2874 |
What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.
bitrise run test(in the step's repository)bitrise run audit-this-step(in the step's repository - note, if you don't have this workflow in yourbitrise.yml, you can copy it from the step template.)New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.