New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate-text-file 0.0.1 #870
generate-text-file 0.0.1 #870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix these things and then create a new version - please do not remove the existing version, just create a new one (we had issues because of failed attempts to re-create a version before).
commit: 1dd81d6acaf45388a446f85427cb89abdfb64726 | ||
host_os_tags: | ||
- osx-10.10 | ||
project_type_tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove all the project type tags, as this step should work with any kind of project (right?)
type_tags: | ||
- script | ||
- file | ||
- versioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all the non relevant tags, leave only "file" and "utils" (IMO)
summary: Add content for the text file here. You can also use all ENV variables. | ||
title: Content of the text file | ||
outputs: | ||
- GENERATED_TEXT_FILE_PATH: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an issue if you leave this here, but as you have a "file name" input, this output is redundant IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own workflow it'd be really nice to have it as a public env variable afterwards. That's why I added it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be kept, but in general IMO it's better to specify the path in an App Env Var (for example), which then can be used as the file_name
input here, as well as in the other step where you want to consume the file. That makes it a bit more explicit and easier to debug when you work with the bitrise.yml
.
ede81b3
to
8cff784
Compare
Made the changes as requested and opened a PR for a new version ☝️ Closing this PR. |
This step allows users to create a generic text file they can use further down in the process. This is useful for e.g. creating a What's New message for the Play Store deploy step based on the Git commit messages.
New Pull Request Checklist
Please mark the points which you did / accept.
bitrise run test
(in the step's repository)bitrise run audit-this-step
(in the step's repository - note, if you don't have this workflow in yourbitrise.yml
, you can copy it from the step template.)