Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate text file 0.0.2 #872

Merged

Conversation

nicolas-fricke
Copy link
Contributor

This step allows users to create a generic text file they can use further down in the process. This is useful for e.g. creating a What's New message for the Play Store deploy step based on the Git commit messages.

Factored in changes requested in PR #870 and released new version.

New Pull Request Checklist

Please mark the points which you did / accept.

@viktorbenei
Copy link
Contributor

Hi,

How did you share your step? Asking because following the official sharing method (using the CLI) the PR should not include the previous 0.0.1 version.

Did you click "update" on GitHub or something similar?

@viktorbenei
Copy link
Contributor

Can you please simply remove the 0.0.1 from the PR?

Alternatively, you can follow this step by step guide: #811 (comment) - of course Step 1 is to open your fork of the steplib, not the one linked there ;)

@nicolas-fricke
Copy link
Contributor Author

Weird, yes, I used the bitrise share commands and then created a new label and then a PR from the new branch for release 0.0.2. But okay, I'll then just remove the 0.0.1 commit and force push to this branch.

Copy link
Contributor

@viktorbenei viktorbenei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @nicolas-fricke ! 🚀

@viktorbenei viktorbenei merged commit 65ef03e into bitrise-io:master Feb 13, 2017
@viktorbenei
Copy link
Contributor

Thanks for the step @nicolas-fricke , I promise step updates will be faster ;)

We try to be quite thorough for new steps, to make it simple for you in the future to publish updates without breaking changes.

One more thing, as a step maintainer you can request a $25/mo discount - more details: https://discuss.bitrise.io/t/bitrise-contributors/167

Additionally, I can add you to the Bitrise Contributors GitHub and Bitbucket organizations, if you want to - more info: https://discuss.bitrise.io/t/bitrise-steps-community/496

Happy Building! ;)

@nicolas-fricke
Copy link
Contributor Author

Sounds great @viktorbenei! I'd be honored to become part of the contributors orgs 😃

@viktorbenei
Copy link
Contributor

Invoice sent! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants