Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent workflow name validation #173

Closed
koral-- opened this issue Jun 26, 2017 · 4 comments
Closed

Inconsistent workflow name validation #173

koral-- opened this issue Jun 26, 2017 · 4 comments
Assignees
Labels

Comments

@koral--
Copy link

koral-- commented Jun 26, 2017

In graphical workflow editor, the workflow name cannot contain spaces and be empty. However, they can be specified (and saved successfully) using bitrise.yml tab.
Such workflow is later properly handled by editor but not always can be triggered, e.g. when name is empty there is an error: Failed to start Build: trigger pattern did not match any defined mapping.

So it seems that validation in graphical mode is valid but in bitrise.yml tab is too lenient.

@viktorbenei
Copy link
Contributor

Thanks for reporting @koral-- !

The issue here is that technically the CLI allows workflow names with spaces or other special chars in the ID for now. It will print a warning if you e.g. bitrise run any workflow or run any validation on the bitrise.yml, but technically this is not considered an error just yet, mainly because it wasn't a requirement in the past. We will make this an error in a future CLI version, but for now this is just a warning.

Allowing an empty workflow ID on the other hand is definitely an issue, and should be fixed in the CLI - can you please create a ticket there @koral-- ? If it's fixed there it will be in the editor too, as the editor just sends the yml to the CLI when you edit it in yml mode.

@viktorbenei
Copy link
Contributor

Closing as this issue can't be solved in the editor.

@koral--
Copy link
Author

koral-- commented Jun 26, 2017

OK, reported.

@viktorbenei
Copy link
Contributor

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants