Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of 3.0.0 #2

Closed
mswiderski opened this issue Sep 12, 2013 · 13 comments
Closed

Release of 3.0.0 #2

mswiderski opened this issue Sep 12, 2013 · 13 comments

Comments

@mswiderski
Copy link

Are there any plans to release 3.0.0 version as 2.1.x does not work with hibernate 4.2 and above.

@lorban
Copy link
Contributor

lorban commented Sep 12, 2013

I don't think we did anything to 3.0.0 to solve any compatibility issue with Hibernate. Could you please post some details about what's wrong with the 2.1 line and Hibernate 4.2?

@mswiderski
Copy link
Author

@lorban
Copy link
Contributor

lorban commented Sep 12, 2013

I'm not sure we can cut a 3.0.0 release anytime soon. Maybe we could release a 2.1.4 with this fix if you're willing to help?

@mswiderski
Copy link
Author

I guess that would be fine, as this is the main thing we need to have. How could I help?

@lorban
Copy link
Contributor

lorban commented Sep 12, 2013

Have you tried to checkout the 2.1.x code, build it, then try to fix the problem? If you can provide a tested patch I'm okay to start the 2.1.4 release procedure.

@mswiderski
Copy link
Author

let me give it a try to backport the fix from 3.0.0 and test.

@lorban
Copy link
Contributor

lorban commented Sep 12, 2013

By the way, according to the comments Christian Bauer left on BTM-126, Hibernate 4.2.1+ should have fixed this problem, see: https://hibernate.atlassian.net/browse/HHH-7984

Knowing this, do you still consider you need a BTM release?

@mswiderski
Copy link
Author

I would say yes, we are constraints to certain version of hibernate that comes with application server so would be great to have it sorted once and for all.

@mswiderski
Copy link
Author

alright, pull request ready: #3

it wasn't possible to backport the fix from 3.0.0 as there was complete change in proxy handling so added fix for it based on current impl and on the idea from 3.0.0. Hope this makes sense.

Initial tests are positive - entire jbpm code base works as expected, I'll continue with tests on tomcat7 and in gwt hosted mode to make sure all options work properly.

@mswiderski
Copy link
Author

ok, verified it on both tomcat 7 and jetty as part of gwt hosted mode and all works well.

what's your view on the fix? Would it be possible to get 2.1.4 released soon?

@lorban
Copy link
Contributor

lorban commented Sep 13, 2013

I'll review the patch this weekend and perform the release if it looks
right.

On Fri, Sep 13, 2013 at 3:18 PM, Maciej Swiderski
notifications@github.comwrote:

ok, verified it on both tomcat 7 and jetty as part of gwt hosted mode and
all works well.

what's your view on the fix? Would it be possible to get 2.1.4 released
soon?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-24393627
.

@lorban
Copy link
Contributor

lorban commented Sep 15, 2013

AFAICT the 3.0.0 codebase shouldn't have this equality of statements problem with Hibernate 4.2, but I'd be glad if you could try it out.
I've released version 2.1.4 which contains your fix so now both branches not cause that problem anymore.

@lorban lorban closed this as completed Sep 15, 2013
@mswiderski
Copy link
Author

thanks a lot! Already testing the 2.1.4 and so far all looks really good.

when it comes to 3.0.0 it already has fix for the problem as we successfully used it for quite few weeks so both branches are now safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants