-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow owner of a UIA to close markets and stop trading in a UIA #1033
Comments
Please specify more precisely what you mean with "discontinue usage". The two examples given are quite different. |
Thank you for providing the detailed User Story @dnotestein. Please note: I unticked the items in the Core Team Task List within the Description. The intention there is for the Core team to tick them off as the Issue is developed. We also use the |
I guess some of the functionalities (if not all) described in OP are already implemented, check bitshares-core/libraries/chain/include/graphene/chain/protocol/asset_ops.hpp Lines 68 to 71 in f1b19b1
By the way, funds in hacked accounts can also be stuck in other objects e.g. vesting balances, collateral and etc, but not only limit orders. |
@abitmore With the fields you mentioned above, how would you cancel existing orders? Does blacklisting cancel existing orders? Also, what state would you use to say this asset can't be traded in any market? I'm assuming you could use whitelist to say it could only trade against one market, but it's not obvious to me how you could then prevent it from trading in that market. Maybe whitelist it AND blacklist it against that one market? |
@dnotestein If I'm not mistaken, your conclusion is correct. Blacklist "trumps" whitelist so to speak so if you had it whitelisted for one market and then blacklist it, it will in fact disallow trading. |
bitshares-core/libraries/chain/market_evaluator.cpp Lines 45 to 48 in f1b19b1
|
Check asset |
Does blacklisting a market cancel existing orders in that market? Seems like it should if it doesn't. |
It doesn't. The change worth a BSIP. |
@dnotestein mentioned in bitshares/bitshares-ui#2695 (comment):
And there is a related BSIP draft: bitshares/bsips#148 |
https://github.com/bitshares/bsips/blob/master/bsip-0045.md Relevant BSIP - an user could create a smartcoin with your uia as collateral to bypass such rules. |
User Story
As a UIA owner, I want to be able to discontinue usage of my UIA, either temporarily or permanently. One example is that I'm transitioning from an OLD UIA to a new UIA with different characteristics and I want to force an exchange between the two assets. Another case is when the asset gets hacked and I want to claim it back from hacked accounts. In such cases, I can't claim back the asset if the asset is tied up in open exchange orders.
CORE TEAM TASK LIST
The text was updated successfully, but these errors were encountered: