Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Cases for PR 1270 (MCR Bugfix) #1423

Closed
ryanRfox opened this issue Nov 8, 2018 · 4 comments

Comments

@ryanRfox
Copy link
Member

commented Nov 8, 2018

Required Test Cases

  • modify old test cases related to margin calls, see if anything is broken after the new hard fork time
  • reproduce the issue before the hard fork time, aka changing MCR doesn't trigger margin calls (or push some call orders out of margin call territory)
    • go over the hard fork time, check if margin calls are triggered (or no longer triggered) as expected
  • changing MCR again after the hard fork time, check if margin calls are triggered correctly

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@ryanRfox

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

It is my understanding the PR #1324 contains code for the bugfix of #1270 but lacks test cases. This issues to create those test cases.

Once the test cases are added to the PR, we can organize the dates for TESTNET.

@oxarbitrage oxarbitrage self-assigned this Nov 9, 2018

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

closed by #1493 and #1469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.