Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revival of globally-settled assets should depend on ICR but not MCR #2290

Closed
2 of 17 tasks
abitmore opened this issue Oct 16, 2020 · 2 comments · Fixed by #2505
Closed
2 of 17 tasks

Revival of globally-settled assets should depend on ICR but not MCR #2290

abitmore opened this issue Oct 16, 2020 · 2 comments · Fixed by #2505

Comments

@abitmore
Copy link
Member

User Story

As a user I'd like that the globally-settled assets get revived only when CR of existing collateral bids plus the settlement funds exceed ICR but not only MCR, so that the new debt positions after revival would be farther away from being margin called.

Related:

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)
Add any other context about your request here.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to To Do in Protocol Upgrade Release (6.0.0) via automation Oct 16, 2020
@froooze
Copy link

froooze commented Dec 7, 2020

I don't think ICR should be considered here, MCR is enough.
Revival is old debt -> MCR

@abitmore abitmore moved this from To Do to In Development in Protocol Upgrade Release (6.0.0) Oct 5, 2021
@abitmore abitmore self-assigned this Oct 5, 2021
@abitmore abitmore linked a pull request Oct 6, 2021 that will close this issue
@abitmore abitmore moved this from In Development to In Testing in Protocol Upgrade Release (6.0.0) Oct 6, 2021
@abitmore
Copy link
Member Author

abitmore commented Oct 7, 2021

Done via #2505.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants