Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive GSed bitassets based on ICR rather than MCR #2505

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Revive GSed bitassets based on ICR rather than MCR #2505

merged 3 commits into from
Oct 7, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Oct 6, 2021

PR for #2290.

Feature:

  • Globally-settled assets get revived only when CR of existing collateral bids plus the settlement funds exceed ICR but not only MCR, so that the new debt positions after revival would be farther away from being margin called.

@abitmore abitmore added this to In Development in Protocol Upgrade Release (6.0.0) via automation Oct 6, 2021
@abitmore abitmore moved this from In Development to In Testing in Protocol Upgrade Release (6.0.0) Oct 6, 2021
@abitmore abitmore linked an issue Oct 6, 2021 that may be closed by this pull request
Revival of globally-settled assets should depend on ICR but not MCR #2290
Closed
17 tasks
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

@abitmore abitmore merged commit 7382efd into hardfork Oct 7, 2021
Protocol Upgrade Release (6.0.0) automation moved this from In Testing to Done Oct 7, 2021
@abitmore abitmore deleted the pr-2290-gs-revive-by-icr branch October 7, 2021 22:11
This was referenced Oct 7, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hardfork
Projects
No open projects
Protocol Upgrade Release (6.0.0)
  
Done
Milestone
6.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.

Revival of globally-settled assets should depend on ICR but not MCR
1 participant
@abitmore