Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe suppress p2p logging about liquidity pool "Unable to exchange at expected price" #2543

Closed
2 of 17 tasks
abitmore opened this issue Nov 29, 2021 · 1 comment · Fixed by #2625
Closed
2 of 17 tasks

Maybe suppress p2p logging about liquidity pool "Unable to exchange at expected price" #2543

abitmore opened this issue Nov 29, 2021 · 1 comment · Fixed by #2625
Projects
Feature Release (6.1.0)
Milestone
6.1.0 - Feature R...

Comments

@abitmore
Copy link
Member

abitmore commented Nov 29, 2021 •
edited
Loading

User Story

Found quite some such log messages in p2p.log, likely generated by arbitrage bots.

Related: similar efforts done in the past: #1875.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Nov 29, 2021
@abitmore abitmore added this to To do in Feature Release (6.1.0) via automation Nov 29, 2021
@abitmore abitmore mentioned this issue Aug 9, 2022
Merged
@abitmore abitmore moved this from To do to In progress in Feature Release (6.1.0) Aug 9, 2022
@abitmore abitmore linked a pull request Aug 9, 2022 that will close this issue
Lower log level of unfillable_price exception in liqudity_pool_exchange_operation #2625
Merged
@abitmore
Copy link
Member Author

Fixed by #2625.

Feature Release (6.1.0) automation moved this from In progress to Done Aug 10, 2022
@abitmore abitmore mentioned this issue Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Feature Release (6.1.0)
  
Done
Milestone
6.1.0 - Feature Release
1 participant
@abitmore