Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower log level of unfillable_price exception in liqudity_pool_exchange_operation #2625

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Lower log level of unfillable_price exception in liqudity_pool_exchange_operation #2625

merged 1 commit into from
Aug 10, 2022

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Aug 9, 2022

For #2543.

@abitmore
Lower log level of an exception in LP_exchange_op
d2a56ee 
Specifically, the unfillable_price exception,
usually due to competition among trading bots.
@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Aug 9, 2022
@abitmore abitmore linked an issue Aug 9, 2022 that may be closed by this pull request
Maybe suppress p2p logging about liquidity pool "Unable to exchange at expected price" #2543
Closed
17 tasks
@abitmore
Copy link
Member Author

abitmore commented Aug 9, 2022

macOS build failed with error:

2022-08-09T22:18:48.6623510Z �[0;39;49m/Users/runner/work/bitshares-core/bitshares-core/tests/tests/history_api_tests.cpp:602: �[1;31;49merror: in "history_api_tests/track_account2": check histories.size() == 0u has failed [1 != 0]�[0;39;49m

Will retry.

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@abitmore abitmore marked this pull request as ready for review August 10, 2022 06:17
@abitmore abitmore merged commit bd01d9a into develop Aug 10, 2022
@abitmore abitmore deleted the pr-2543-suppress-p2p-logging branch August 10, 2022 06:17
@abitmore abitmore mentioned this pull request Aug 10, 2022
Closed
17 tasks
@abitmore abitmore mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0 - Feature Release
Development

Successfully merging this pull request may close these issues.

Maybe suppress p2p logging about liquidity pool "Unable to exchange at expected price"
1 participant
@abitmore